[HUDI-8782] BulkInsertWriterHelper parallel close #12518
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Dec 19, 2024
| }).join(); | ||
| try { | ||
| executorService.shutdown(); | ||
| executorService.awaitTermination(24, TimeUnit.DAYS); |
There was a problem hiding this comment.
Sorry! 24 hours. this indicates a long timeout , aiming to waiting for all handles closed.
There was a problem hiding this comment.
Still too long, the close should be fast right?
There was a problem hiding this comment.
Still too long, the close should be fast right?
I agree, close should be fast. here awaitTermination is actually a timeout, 24 Hours is too long , how about wait for a Flink CP interval?
There was a problem hiding this comment.
Did you estimate the normal time cost for the close? Maybe just 1 minute should be enough.
There was a problem hiding this comment.
1 minute maybe not enough when HDFS is busy. or we can make this a config and set default value 1 minute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
closeis slow when large amount rowCreateHandles in BulkInsertWriterHelper, this PR close this handles in parallel.Impact
hudi-flink-datasource
Risk level (write none, low medium or high below)
Low
Documentation Update
None
Contributor's checklist